bug: HttpExecutor was swallowing server URL path; OpenAPIExecutor caching same server URL and operationId #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
reviewed
Nov 19, 2025
impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutor.java
Outdated
Show resolved
Hide resolved
fjtirado
reviewed
Nov 19, 2025
impl/core/src/test/java/io/serverlessworkflow/impl/WorkflowUtilsTest.java
Show resolved
Hide resolved
fjtirado
reviewed
Nov 19, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Show resolved
Hide resolved
fjtirado
reviewed
Nov 19, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Show resolved
Hide resolved
fjtirado
reviewed
Nov 19, 2025
impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OpenAPIExecutor.java
Show resolved
Hide resolved
…ver + op; Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
fjtirado
approved these changes
Nov 19, 2025
fjtirado
reviewed
Nov 19, 2025
impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowUtils.java
Outdated
Show resolved
Hide resolved
fjtirado
approved these changes
Nov 19, 2025
fjtirado
reviewed
Nov 19, 2025
impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
force-pushed
the
fix-openapiurl
branch
from
35e6e9c to
2e338ea
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
In this PR:
server.urlwith path, e.g.https://localhost/v1/api. Paths were returning likehttps://localhost/petsinstead ofhttps://localhost/v1/api/pets.OpenAPIExecutorwas caching oneHttpExecutorper document, not per document + operation. The side effect is that if I have a workflow accessing the same document, but with different operations, only the first operation is called.Special notes for reviewers:
Additional information (if needed):